feat: add env:*#2110
Conversation
🦋 Changeset detectedLatest commit: eeb2093 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
themavik
left a comment
There was a problem hiding this comment.
Code review
convertObjectToModule in packages/start/src/config/env.ts has a console.log(result) on line 46 — that will log the generated module string on every env load. Should be removed before merge.
atilafassina
left a comment
There was a problem hiding this comment.
before merging this one, let's make sure we have some tests.
specially assuring that there's no way secrets can leak
f5bfb8c to
eeb2093
Compare
|
Nice, this is a great feat, ensuring server and client env is loaded differently! |
This PR adds the
env:serverandenv:clientmodulescloses #2113